Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the parsing and the IO #107

Open
hardbyte opened this issue Dec 9, 2016 · 2 comments
Open

Split the parsing and the IO #107

hardbyte opened this issue Dec 9, 2016 · 2 comments

Comments

@hardbyte
Copy link
Owner

hardbyte commented Dec 9, 2016

I'm convinced we should clearly split the parsing and the IO for each interface. This obviously effects the entire library - but it should all be internal changes.

See this http 1.1 example or this great pycon16 talk.

@felixdivo
Copy link
Collaborator

I just watched that talk you linked yesterday and now get what you meant. ^^ I initially thought about the current can.io.* package which didn't make too much sense.

I totally agree with the need for splitting the parsing and the I/O. Although I think it would mainly benefit the testing & readability of this library, rather than the reusability in other projects. But who knows.

But there are a few more problems that I personally had with understanding the code of this library, which should be part of this discussion. I think a lot of the project structure could be made quite a bit simpler to make it easier to get started. When I have some time I will open a separate Issue for that to start a discussion on that in general.

@felixdivo
Copy link
Collaborator

@hardbyte Is this also a discussion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants