Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read-write access when opening files with external apps #54

Closed
badrow opened this issue Oct 19, 2021 · 6 comments
Closed

Allow read-write access when opening files with external apps #54

badrow opened this issue Oct 19, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@badrow
Copy link

badrow commented Oct 19, 2021

Hi, the app currently doesn't allow to edit files. Even if we open it with an external app, when we want to save it, we got an error.
Am I doing something wrong ? Or is it just not compatble ?

Thank you for your work, great to see gocryptfs support on android !

@hardcore-sushi
Copy link
Owner

For my part, I can edit text files perfectly with the DroidFS built-in editor (note that the volume needs to be on a writable location, you can't edit files inside volumes located on external SD cards).
DroidFS only grants read-only access to external apps. This is why you can't edit encrypted files with other apps.
Can you give more information on the issue? (DroidFS & Android version, volume path, error messages if any, logcat...)

@badrow
Copy link
Author

badrow commented Oct 27, 2021

For my part, I can edit text files perfectly with the DroidFS built-in editor (note that the volume needs to be on a writable location, you can't edit files inside volumes located on external SD cards). DroidFS only grants read-only access to external apps. This is why you can't edit encrypted files with other apps. Can you give more information on the issue? (DroidFS & Android version, volume path, error messages if any, logcat...)

Okay sorry. So it's a correct behaviour of the app. I can edit a txt file in the droidfs app but not from another app. Is it possible to add an option to allow write access to external app ?

Thank you !

@hardcore-sushi hardcore-sushi changed the title Unable to edit file Allow read-write access when opening files with external apps Oct 28, 2021
@hardcore-sushi hardcore-sushi added the enhancement New feature or request label Jan 5, 2022
@adam144dev
Copy link

adam144dev commented May 9, 2023

HI
what about adding this feature, it seems crucial for me to able to use it "as on desktop" ?

ps
That's why I still use Cryptomator but this encrypting technologi seems to be much better, I mean speed on PC is much higher.
So Im rely interesting in that feature

@hardcore-sushi
Copy link
Owner

This has been added with v2.1.0.

@thangtranxuan-vti
Copy link

thangtranxuan-vti commented Sep 25, 2023

I've enabled 2 unsafe options "Allow opening files with other applications" and "Grant write access", but editing and saving files in a gocryptfs vault using an external app still has no effect. I'm using Markor for editing a .md file. I'm not sure if it is Markor's fault or DroidFS's.

@hardcore-sushi
Copy link
Owner

According the Markor source code, it seems that the file is copied into the app's internal storage if a path can't be retrieved from the intent: GsContextUtils.java:1673.

I can confirm that Markor copies files opened from DroidFS in /data/data/net.gsantner.markor/cache/CONTENT_RESOLVER_FILE_PROXY_SEGMENT/. DroidFS cannot provide a path to markor since the file could only be stored in memory (on-disk file is encrypted). Maybe a patch could be submitted to Markor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants