You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the json config file all the arguments must be set per record. In some cases like chromedriver, the argument is the same across all the records. I propose to read such 'global' arguments for all the records to avoid duplication.
If the global argument is defined in both places (the record and the global section) then we can either override the record specific with the global (or vice versa), or fail the process to force the user to use one of both. I lean towards overwriting the global using the record specific argument.
Based on the arguments from args_list I think should the following should be "global":
chromedriver
usage_rights
exact_size
aspect_ratio
type
specific_site
print_paths
safe_search
language
I'm happy to raise a PR to implement this change if it sounds ok :-)
The text was updated successfully, but these errors were encountered:
When using the json config file all the arguments must be set per record. In some cases like
chromedriver
, the argument is the same across all the records. I propose to read such 'global' arguments for all the records to avoid duplication.It would be something like:
As opposed to:
If the global argument is defined in both places (the record and the global section) then we can either override the record specific with the global (or vice versa), or fail the process to force the user to use one of both. I lean towards overwriting the global using the record specific argument.
Based on the arguments from
args_list
I think should the following should be "global":I'm happy to raise a PR to implement this change if it sounds ok :-)
The text was updated successfully, but these errors were encountered: