Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date and Currency Formats #3

Closed
TopicsLP opened this issue Jan 6, 2024 · 7 comments
Closed

Date and Currency Formats #3

TopicsLP opened this issue Jan 6, 2024 · 7 comments

Comments

@TopicsLP
Copy link

TopicsLP commented Jan 6, 2024

Issue

With the date format MM/DD/YYYY the application can be open for confusion for the rest of the globe using different formats like:

  • DD.MM.YYYY
  • YYYY-MM-DD

The currency of $/USD may not be appealing to everyone, considerations should be taken to include other common values.

Proposed Solutions

For the date format you maybe able to add a setting to toggle to use a display of the date based on ISO8601/RFC3339 YYYY-MM-DD this is probably the simplest solution and I think a good compromise, but maybe also a drop-down to just selected the favored date format.

Currency, similar approach could be taken in the settings a drop-down to select common currency's:

  • $ (USD)
  • € (EUR)
  • £ (GBP)
  • Fr. (CHF)
@hargata hargata mentioned this issue Jan 6, 2024
@hargata
Copy link
Owner

hargata commented Jan 6, 2024

@TopicsLP I was able to see the currency and date format changes by changing the regional culture on my computer, example(in English(Germany) is selected):
image

Is there a potential use case where the user might have their culture set to something else but need the currency on the app to display in another culture?

@TopicsLP
Copy link
Author

TopicsLP commented Jan 6, 2024

Ok I did not verify that first,so besides the docker container issue it is not needed.
I agree on that most likely nearly no one needs a different date and currency format to their system locals, but maybe Linux (Desktop) Users ?

@manawenuz
Copy link

how do you change the regional culture on your docker container ?
also adding currency conversion at the time of fueling using an API would be super

@hoferbeck
Copy link

hoferbeck commented Jan 7, 2024

how do you change the regional culture on your docker container ?

I was able to change the culture by changing two Lines in the Dockerfile:
from:

ENV LC_ALL=en_US.UTF-8 \
    LANG=en_US.UTF-8

to

ENV LC_ALL=de_DE.utf8 \
    LANG=de_DE.utf8

Its now looking better (but it seems to me, that the header isn't dynamic)
Screenshot 2024-01-07 113945

EDIT:

I oversaw that, I can set in the settings, to use Liters instead of Gallons (would be nice, if that is set by the Local Variables).
But the Date is still "wrong" MM-DD-YYYY instead of DD.MM.YYYY or YYYY-MM-DD

Now it looks like this for me:
grafik

@manawenuz
Copy link

ok, thank god, it doesn't change the language, i thought it's to change the language, and the word culture i guess is something from windows world and it was rather confusing, thanks, it solved my issue.

@florianschroen
Copy link
Contributor

florianschroen commented Jan 7, 2024

Only locale has been changed, which is for character encoding, primarily.

See https://wiki.debian.org/Locale for reference.

@hargata
Copy link
Owner

hargata commented Jan 12, 2024

most if not all issues with locale has been fixed including decimal formatting for input and display.

@hargata hargata closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants