Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline does not fail with ci renderer when there is a mismatch #34

Closed
laurinenas opened this issue Nov 17, 2022 · 5 comments
Closed

Comments

@laurinenas
Copy link

Hey,

First of all, thanks for amazing project!

I have added npmvet -r ci to pipeline hoping it would start failing the pipeline if there is a version mismatch. There is a new mismatch, but the pipeline does not fail and the command has exited with 0 error code.

Am I using it not in a proper way?

Thanks for your answer!

@laurinenas laurinenas changed the title Pipeline does not fail with ci renderer and mismatch in versions Pipeline does not fail with ci renderer when there is a mismatch in versions Nov 18, 2022
@laurinenas laurinenas changed the title Pipeline does not fail with ci renderer when there is a mismatch in versions Pipeline does not fail with ci renderer when there is a mismatch Nov 18, 2022
@andrewhathaway
Copy link
Member

Hi @laurinenas! Can you try with the -s flag added too please, that enables strict mode we should fix the problem.

@laurinenas
Copy link
Author

Hey thanks @andrewhathaway for the response!

If that is any help we are running npmvet v0.2.0 on bitbucket pipelines. Both:
- npx npmvet -r -s ci and
- npx npmvet -rs ci

got a 0 return code, i.e. green pipeline.

Am I using it correctly?

@andrewhathaway
Copy link
Member

@laurinenas I haven't used it with Bitbucket Pipelines but we've been running this in Production on Azure Pipelines for multiple years with the following: npmvet -r ci -s.

The issue with your commands above is that -r (renderer flag) has an argument (ci) which is required directly after -r.

@slieschke
Copy link
Contributor

The command line arguments are getting ignored in the v0.2.0 release, I've submitted a PR that fixes this at #37.

@andrewhathaway
Copy link
Member

Thank you @slieschke! I have released v0.2.1 now with your fix - @laurinenas this should also resolve your issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants