-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline does not fail with ci renderer when there is a mismatch #34
Comments
Hi @laurinenas! Can you try with the |
Hey thanks @andrewhathaway for the response! If that is any help we are running npmvet v0.2.0 on bitbucket pipelines. Both: got a 0 return code, i.e. green pipeline. Am I using it correctly? |
@laurinenas I haven't used it with Bitbucket Pipelines but we've been running this in Production on Azure Pipelines for multiple years with the following: The issue with your commands above is that -r (renderer flag) has an argument ( |
The command line arguments are getting ignored in the v0.2.0 release, I've submitted a PR that fixes this at #37. |
Thank you @slieschke! I have released v0.2.1 now with your fix - @laurinenas this should also resolve your issue! |
Hey,
First of all, thanks for amazing project!
I have added
npmvet -r ci
to pipeline hoping it would start failing the pipeline if there is a version mismatch. There is a new mismatch, but the pipeline does not fail and the command has exited with 0 error code.Am I using it not in a proper way?
Thanks for your answer!
The text was updated successfully, but these errors were encountered: