fix: optionally dedupe with meta props

harlan-zw · Nov 16, 2022 · 3277488 · 3277488
1 parent 88ec4cd
commit 3277488
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/zhead/src/tagDedupeKey.ts b/packages/zhead/src/tagDedupeKey.ts
@@ -9,7 +9,11 @@ const ArrayMetaProperties = [
   'music:album', 'music:musician',
 ]
 
-export function tagDedupeKey<T extends HeadTag>(tag: T): string | false {
+export function tagDedupeKeyWithMetaProps<T extends HeadTag>(tag: T): string | false {
+  return tagDedupeKey(tag, (val) => ArrayMetaProperties.findIndex(p => val.startsWith(p)) === -1)
+}
+
+export function tagDedupeKey<T extends HeadTag>(tag: T, fn?: (key: string) => boolean): string | false {
   const { props, tag: tagName } = tag
   // must only be a single base so we always dedupe
   if (UniqueTags.includes(tagName))
@@ -30,7 +34,7 @@ export function tagDedupeKey<T extends HeadTag>(tag: T): string | false {
     // open graph props can have multiple tags with the same property
     if (typeof props[n] !== 'undefined') {
       const val = String(props[n])
-      if (ArrayMetaProperties.findIndex(p => val.startsWith(p)) !== -1)
+      if (fn && !fn(val))
         return false
       // for example: meta-name-description
       return `${tagName}:${n}:${val}`

diff --git a/test/zhead/tagDedupeKey.test.ts b/test/zhead/tagDedupeKey.test.ts
@@ -1,4 +1,4 @@
-import { tagDedupeKey } from 'zhead'
+import {tagDedupeKey, tagDedupeKeyWithMetaProps} from 'zhead'
 
 describe('tagDedupeKey', () => {
   test('title key', async () => {
@@ -63,7 +63,7 @@ describe('tagDedupeKey', () => {
   })
 
   test('og exception', async () => {
-    const key = tagDedupeKey({
+    const key = tagDedupeKeyWithMetaProps({
       tag: 'meta',
       props: {
         property: 'og:image',