You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello @harlexkhal we took a look at your project and we liked what you did. we observed that you followed good coding practices including
No linter issues
git flow
writing meaningful commit messages
However we also observed that you did not follow some practices as they are supposed to be implemented.
Please consider breaking the project to small tasks and working on them in different branches as opposed to having one long Pull request
Consider using a paradigm that is understood by your teammates to avoid conflicts and most importantly to give the code reviewers an easy time when reviewing your code,
with no further issues to mention we think in general you did a good job on the project and Kudos to you and your partner.
The text was updated successfully, but these errors were encountered:
Hello @harlexkhal we took a look at your project and we liked what you did. we observed that you followed good coding practices including
However we also observed that you did not follow some practices as they are supposed to be implemented.
with no further issues to mention we think in general you did a good job on the project and Kudos to you and your partner.
The text was updated successfully, but these errors were encountered: