Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-review week-5 module 2 #28

Closed
daudi13 opened this issue Mar 10, 2022 · 0 comments
Closed

Peer-review week-5 module 2 #28

daudi13 opened this issue Mar 10, 2022 · 0 comments

Comments

@daudi13
Copy link

daudi13 commented Mar 10, 2022

Hello @harlexkhal we took a look at your project and we liked what you did. we observed that you followed good coding practices including

  • No linter issues
  • git flow
  • writing meaningful commit messages

However we also observed that you did not follow some practices as they are supposed to be implemented.

  • Please consider breaking the project to small tasks and working on them in different branches as opposed to having one long Pull request
  • Consider using a paradigm that is understood by your teammates to avoid conflicts and most importantly to give the code reviewers an easy time when reviewing your code,

with no further issues to mention we think in general you did a good job on the project and Kudos to you and your partner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants