New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Responsiveness #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 well done with the Responsiveness its what makes a great application and good job you've taken it into account. as I know you would always do a better job than me when it comes to making good UI. just a few changes regarding project documentation on the Readme and License information
MIT.md
Outdated
@@ -0,0 +1,10 @@ | |||
## Copyright 2021, [Mnemba Chambuya] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my name should also be here, I guess you forgot 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 yes, most definitely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
README.md
Outdated
- JavaScript, HTML, CSS | ||
|
||
## Live Demo (if available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can Remove the "(if available)", because we have made sure the live link is available already. saying (if available) is making it uncertain that it might not be there, what do you think 😄
README.md
Outdated
- LinkedIn: [mnemba-chambuya](https://linkedin.com/in/mnemba-chambuya) | ||
|
||
## Screenshot ![see](./src/assets/images/screenshot.png?raw=true "Title") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this image should be at the top of the Readme file. instead of the bottom. this shows a full view of what the app looks like before diving into other details like how it works and cloning it, what do you think about it 🧇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an interesting point of view and I agree with you. It could provide a better overview of the app. But, I used the Microverse README.md template. Could we make the improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sure we can 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an example of a readme I've done on a previous project https://github.com/harlexkhal/Leaderboard/blob/development/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Description
In this milestone, I added responsiveness to the site to make it look decent on smaller devices.
Type of change
Checklist: