Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: Components #2

Merged
merged 4 commits into from Mar 15, 2022
Merged

Math magicians: Components #2

merged 4 commits into from Mar 15, 2022

Conversation

harlexkhal
Copy link
Owner

@harlexkhal harlexkhal commented Mar 15, 2022

  • Delete all the boilerplate from CRA (text, images, styles).
  • Create a directory called components.
  • Inside components, create a new Calculator.js file.
  • In Calculator.js, create a React component that matches the design given
  • No addition of extra design.
  • Developed just the UI of the calculator
  • Use class-based components.
  • imported Calculator.js for use in the main component (App.js).
  • Tested in the browser, and renders without problems.

Copy link

@dasileker dasileker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harlexkhal,

Congratulations! 🎉

Your project is complete! There is nothing else to say other than... it's time to merge it 🚀 :

Optio,al

  • The readme file getting starter, licence, author should be more understandble.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@harlexkhal harlexkhal merged commit b77a796 into development Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants