Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: Events #5

Closed
wants to merge 3 commits into from
Closed

Math magicians: Events #5

wants to merge 3 commits into from

Conversation

harlexkhal
Copy link
Owner

@harlexkhal harlexkhal commented Mar 16, 2022

  • Copied the files Calculate.js and Operate.js into a logic/ directory in your project.
  • Analyzed the files Calculate.js and Operate.js and understood what they did.
  • Imported the files in your Calculator component.
  • Implemented the event handlers I needed to use the math logic from Calculate.js and Operate.js in your React component.
  • Practiced what I've learned from state and props, passing props to child components, using lifecycle methods, and lifting the state up.
  • Tested app in the browser. to make sure it performed all the math operations.
  • Launched to GitHub pages here

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harlexkhal,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

  • Nice styling ✔️

You can do it

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

);
}
}
const Calculator = () => {
Copy link

@Meltrust Meltrust Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the project requirements:

image

Therefore:

  • Please, kindly use lifecycle methods on your project, like componentDidMout for instance.

That way, we will meet this particular requirement.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha 💯

Copy link

@dasileker dasileker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harlexkhal,

Congratulations! 🎉

Your project is complete! There is nothing else to say other than... it's time to merge it 🚀 :

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@harlexkhal
Copy link
Owner Author

Thanks for the review 😃

@harlexkhal harlexkhal closed this Mar 16, 2022
@harlexkhal harlexkhal deleted the Logic branch March 16, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants