Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent commits on the same session can cause conflicts to go undetected #14

Closed
GoogleCodeExporter opened this issue Mar 24, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Create a new session.
2. Check out the new session to two workdirs, workdir1 and workdir2.
3. Add some large files to workdir1 so that it will take a long time to commit.
4. Start committing the changes to workdir1.
5. Add some small files to workdir2 so that it will commit quickly.
6. Commit the changes to workdir2 before the workdir1 commit has completed.

What is the expected output? What do you see instead?

Both commits will succeed. The slow commit will be the last to finish, and will 
be the latest revision of the session, hiding the changes committed in workdir2.

The commit to workdir2 should fail with an error message "This session is 
currently being updated. Try again later." (Or, the commit could simply wait 
until the other commit is finished, but the likely result then will also be an 
error, "Your workdir is our of date. You need to update your workdir before you 
can commit")


Original issue reported on code.google.com by ekb...@gmail.com on 22 Mar 2011 at 11:35

@GoogleCodeExporter
Copy link
Author

Better summary

Original comment by ekb...@gmail.com on 24 Mar 2011 at 12:15

  • Changed title: Concurrent commits on the same session can cause conflicts to go undetected

@GoogleCodeExporter
Copy link
Author

Fixed in changeset 309:f7bdde3911cc.

Original comment by ekb...@gmail.com on 24 Mar 2011 at 10:42

  • Changed state: Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant