Add tag filter when call build list endpoint #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bradrydzewski @eoinmcafee00 any update on this? 馃檹 |
|
Hey @michelangelomo Thank you for your submission, it looks good however to merge it can you please add a unit test? Cheers, |
|
Hi @eoinmcafee00, totally reasonable 馃槃 I've added the unit test and the build passes, could you please leave a review? 馃殌 |
eoinmcafee00
approved these changes
Jan 11, 2022
ivanvc
pushed a commit
to ivanvc/drone
that referenced
this pull request
Dec 14, 2023
* Add tag filter when call build list endpoint * Add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering by tag will be very useful for us when we calls builds list endpoint.
Basically I assume
branchandtagfilters can't be defined together and I think those kind of parameters can be handled better but it requires a major refactor, the sqlx part too.@bradrydzewski @eoinmcafee00 if this PR looks good could you merge ASAP? Thank you 馃檹