Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template converter, don't skip .yaml extension. #3242

Merged

Conversation

staffanselander
Copy link

@staffanselander staffanselander commented Jul 20, 2022

I started running into issues when trying out the templating feature of Drone. Most of our dronefiles are using the .yaml extensions rather than the shorter .yml extension. The template converter ignores for any Dronefile that isn't using the shorter .yml extension.

This pull-request will allow the template converter to accept .yaml extensions as-well.

I believe this pull-request would also fix the issue described here: #3237

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@staffanselander staffanselander marked this pull request as ready for review July 20, 2022 21:06
@joshpaulchan
Copy link

This would be great, because the yaml creator UI marks the extension as .yaml - https://github.com/drone/drone-ui/blob/131c5894f2ed1419ab6616ec7c3c4e5178be1a58/src/pages/settings/templates/templates.jsx#L23

@eoinmcafee00 eoinmcafee00 merged commit 82a7b11 into harness:master Aug 1, 2022
@staffanselander staffanselander deleted the template-converter-yaml-skipped branch August 1, 2022 09:44
@tphoney tphoney added the bug label Sep 21, 2022
ivanvc pushed a commit to ivanvc/drone that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants