Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up parsing expressions #26

Closed
3 tasks done
harpocrates opened this issue Aug 16, 2017 · 1 comment
Closed
3 tasks done

Clean up parsing expressions #26

harpocrates opened this issue Aug 16, 2017 · 1 comment

Comments

@harpocrates
Copy link
Owner

harpocrates commented Aug 16, 2017 •
edited
Loading

Right now, due to a happy bug, the expression grammar is difficult to refactor (moving productions around changes the semantics!!). Once this is resolved, several things need to happy:

  • re-organize productions (not just expressions) so that they are grouped more nicely
  • factor out repeated productions in the expression grammar (and group expressions together)
  • test the currently commented out fix for parsing expressions start in union, but that are not unions (e.g. union.tag + 1 - union is a "weak" keyword")
@harpocrates
Copy link
Owner Author

Note that the second and third bullet points have been handled in the WIP-happy1.9.6 branch, which requires my latest (patched) version of happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harpocrates