Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in README is incorrect #311

Closed
haneefkassam opened this issue Feb 22, 2023 · 1 comment · Fixed by #314
Closed

Example in README is incorrect #311

haneefkassam opened this issue Feb 22, 2023 · 1 comment · Fixed by #314

Comments

@haneefkassam
Copy link

In the README.md, the examples provided in the "Last weekday of the month" section are incorrect, and lead to some confusion.

The README indicates that "the cron expression to run on the last monday of the month at midnight" is "0 0 * * * 1L". However, since this is a 6-element cron expression, what this really represents is "every hour, on the hour, on the last monday of the month".

To run on the last monday of the month at midnight, the expression in the example needs 1 more 0, so "0 0 0 * * 1L".

It's not clear, but the second example in that section may also need this additional 0 (it doesn't specify the time).

@harrisiirak
Copy link
Owner

Hi @haneefkassam!

Thanks for reporting this. You're correct indeed.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants