Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native 0.47 errors onChange #8

Closed
KaniRobinson opened this issue Aug 3, 2017 · 2 comments
Closed

React-Native 0.47 errors onChange #8

KaniRobinson opened this issue Aug 3, 2017 · 2 comments

Comments

@KaniRobinson
Copy link
Contributor

React-Native Errors on
onChange={(event) => { this.setState({ textInputHeight: this.props.textInputMinHeight >= event.nativeEvent.contentSize.height ? this.props.textInputMinHeight : event.nativeEvent.contentSize.height, }); } }
at event.nativeEvent.contentSize.height

@jensoleg
Copy link

jensoleg commented Aug 28, 2017

Got the same error om RN 0.47
This might be because of a breaking change in RN 0.46

facebook/react-native@bac84ce

Change OnChange to onContentSizeChange in this lib's index.js file and things will work again

Didn't notice already a PR. check it out

@harshq
Copy link
Owner

harshq commented Aug 28, 2017

Hey! @KaniRobinson Was bit busy with the work lately. Will merge your PR tomorrow. Thanks for that.

@harshq harshq closed this as completed Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants