mix implementation is not correct

[iamstarkov]

these tests from libsass’s spec. For me they are not working in https://github.com/iamstarkov/postcss-color-mix

[iamstarkov]

it doesn’t work for actual examples from libsass, like

a { color: mix(#f00, #00f); }
=> a { color: #800080; } /* which is identical to purple if you using http://sassmeister.com/ */

but color.mix is resulting #4000bf, which is wrong.

[iamstarkov]

probably these failing tests are similar to #46

[MoOx]

What is the purpose of this PR. Will you fix those?

[iamstarkov]

Purpose of this pr is a proof, that mix is broken right now. Mainly because issues like #46 only stating that there are some errors in implementations, while waisting your time to find negative test

[iamstarkov]

Will you fix those?

Should I? If you have no time or will to do it, then yes, I will take it.
The question is, do you want to do it yourself?

[MoOx]

No time for this right now. Too busy with other stuff :)

[iamstarkov]

okie-dokie, will do it

[iamstarkov]

will close and re-open when will be ready

[iamstarkov]

my fix is already done, but I have one question.

are you avoiding named tests and mocha as test runner?
Just for me in development it.only and endless watching are priceless features, so I a refactored test a bit. For testing these features clone my fork and run mocha or mocha -w in development mode. So the question is should I revert my changes before open pull-request or you are fine with mocha?

[MoOx]

legacy from the original author of the module.

I use tape everyday, so I would like to see this one :)

But since I didn't do anything yet, I guess mocha is better than nothing. Feel free to push :)

[iamstarkov]

Done and tests are green!

[MoOx]

Do you confirm that this is a patch only ? (So I can release as a patch)

[iamstarkov]

formally, it is a patch, because previous implementations was incorrect. I only properly ported C implementation

[iamstarkov]

7,616 downloads in the last day

but, i’m afraid that this method can be used by somebody and they dont expect their site to be totally different after patch deps-bump

[iamstarkov]

so probably it is backwards-incompatible patch, but im not sure

[MoOx]

Since we are in 0.x, I will release 0.x+1 :)

[iamstarkov]

valid point!

[iamstarkov]

as far as we switching to mocha, I updated instructions

[MoOx]

Does this fix #46 btw ?

[MoOx]

Released as 0.9.0