New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question in subsequent_mask #27

Closed

wuchen95 opened this issue Mar 15, 2019 · 1 comment

wuchen95 commented Mar 15, 2019

Why use
subsequent_mask = np.triu(np.ones(attn_shape), k=1).astype('uint8')
return torch.from_numpy(subsequent_mask) == 0

I think
return torch.from_numpy(np.tril(np.ones(attn_shape), k=0).astype('uint8'))
maybe is a more clear writing style for a new learner?

wuchen95 closed this as completed

SCNUJackyChen commented Aug 20, 2019

Maybe it just looks more tricky and more pythonic, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment