Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect memory unit conversion in namespace resource quota #1454

Closed
janeczku opened this issue Oct 20, 2021 · 1 comment
Closed

[BUG] Incorrect memory unit conversion in namespace resource quota #1454

janeczku opened this issue Oct 20, 2021 · 1 comment
Assignees
Labels
area/dashboard Harvester/Rancher dashboard area/ui kind/bug Issues that are defects reported by users or that we know have reached a real release priority/0 Must be fixed in this release
Milestone

Comments

@janeczku
Copy link
Contributor

rancher/dashboard#4417

@janeczku janeczku added the kind/bug Issues that are defects reported by users or that we know have reached a real release label Oct 20, 2021
@guangbochen guangbochen added the area/dashboard Harvester/Rancher dashboard label Oct 20, 2021
@guangbochen guangbochen added this to the v1.0.0 milestone Oct 21, 2021
@guangbochen guangbochen added area/ui priority/1 Highly recommended to fix in this release labels Oct 21, 2021
@WuJun2016 WuJun2016 self-assigned this Oct 26, 2021
@guangbochen guangbochen added priority/0 Must be fixed in this release and removed priority/1 Highly recommended to fix in this release labels Oct 26, 2021
@TachunLin TachunLin self-assigned this Nov 29, 2021
@TachunLin
Copy link

Verified fixed on rancher v2.6.3-rc2 and harvester master-47ea94ee-head. Close this issue.

Result

Based on configured project resource limit and namespace default limit,
The memory limit of 256 Megabytes and memory reservation of 128 Megabytes can be configured and applied correctly.

image

image

image

And can create deployment with resource limit correctly.
image

image

image

Test Information

  • Test Environment: 3 nodes harvester on local kvm machines
  • Harvester version: master-47ea94ee-head
  • Rancher version: v2.6.3-rc2

Verify Steps

  1. Access Rancher dashboard
  2. Open Cluster management -> Explore the active cluster
  3. Create a new project test-1454-proj in Projects/Namespaces
  4. Set resource quota for the project
  • Memory Limit:
    • Project Limit: 512
    • Namespace default limit: 256
  • Memory Reservation:
    • Project Limit: 256
    • Namespace default limit: 128
  1. Click create namespace test-1454-ns under project test-1454-proj
  2. Click Kubectl Shell and run the following command
  • kubectl get ns
  • kubectl get quota -n test-1454-ns
  1. Check the output
  2. Click Workload -> Deployments -> Create
  3. Given the Name, Namespace and Container image
    image
  4. Click Create

Additional Context

The harvester cluster in Virtualization Management also passed the test scenario (except the deployment)

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Harvester/Rancher dashboard area/ui kind/bug Issues that are defects reported by users or that we know have reached a real release priority/0 Must be fixed in this release
Projects
None yet
Development

No branches or pull requests

4 participants