Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cluster member can create namespace, but has no access to view it after creation #2309

Closed
WuJun2016 opened this issue May 24, 2022 · 3 comments
Assignees
Labels
area/backend area/multi-tenancy kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue priority/0 Must be fixed in this release
Milestone

Comments

@WuJun2016
Copy link
Contributor

Describe the bug

cluster member can create namespace, but has no access to view it after creation,

To Reproduce
Steps to reproduce the behavior:

  1. create a user, choose Standard User
  2. assign a harvester cluster to the new user and select cluster member
    image.png
  3. login with this user and go to the harvester cluster
  4. at this point you can only see the resources in the harvester-public namespace, and you cannot edit them (as expected)
  5. go to Project/Namespace page, and create a project (cluster-member-project)
  6. Create a namespace (cluster-member-namespace) in the cluster-member-project
    image.png
  7. at this point the user can create resources under cluster-member-namespace
  • Problem 1: The Create button is not displayed in the volume page (backend issue)
  • Problem 2: Users should not create resources in the harvester-public namespace, but the image creation page can select harvester-public (UI issue)
    image.png
  1. go to Project/Namespace page, Create a namespace that does not belong to any Project (such as test-no-namespace)

  2. refresh page, This user does not have permission to view test-no-namespace (backend issue)
    image.png

Expected behavior

Support bundle

Environment:

  • Harvester ISO version:
  • Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

@WuJun2016 WuJun2016 added area/backend area/multi-tenancy area/ui kind/bug Issues that are defects reported by users or that we know have reached a real release labels May 24, 2022
@rebeccazzzz rebeccazzzz added this to the v1.1.0 milestone May 24, 2022
@guangbochen guangbochen added priority/0 Must be fixed in this release backport-needed/1.0.3 labels May 25, 2022
@WuJun2016 WuJun2016 removed the area/ui label May 26, 2022
@guangbochen guangbochen self-assigned this May 26, 2022
@guangbochen guangbochen modified the milestones: v1.1.0, v1.0.3 Jun 16, 2022
@guangbochen guangbochen assigned futuretea and unassigned guangbochen Jul 4, 2022
@futuretea
Copy link
Contributor

futuretea commented Jul 5, 2022

  • Problem 1: The Create button is not displayed in the volume page (backend issue)

image

unable to reproduce, user can see the Create button in the volume page


refresh page, This user does not have permission to view test-no-namespace (backend issue)

even if it's not a Harvester cluster, it has the same behavior, so I'm not sure if this is the behavior that Rancher itself expects

Since Rancher permissions are configured according to project, a namespace that is not associated with a project should be invisible to the standard user.

harvester-public is visible because Harvester does something special.

cc @guangbochen

@futuretea futuretea added the not-require/test-plan Skip to create a e2e automation test issue label Jul 6, 2022
@harvesterhci-io-github-bot
Copy link

harvesterhci-io-github-bot commented Jul 11, 2022

Pre Ready-For-Testing Checklist

* [ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
The HEP PR is at:

* [ ] Where is the reproduce steps/test steps documented?
The reproduce steps/test steps are at:

* [ ] Is there a workaround for the issue? If so, where is it documented?
The workaround is at:

* [ ] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
The PR is at:

* [ ] Does the PR include the explanation for the fix or the feature?

* [ ] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
The PR for the YAML change is at:
The PR for the chart change is at:

* [ ] If labeled: area/ui Has the UI issue filed or ready to be merged?
The UI issue/PR is at:

* [ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
The documentation/KB PR is at:

* [ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?
- The automation skeleton PR is at:
- The automation test case PR is at:

* [ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
The compatibility issue is filed at:

@TachunLin TachunLin self-assigned this Jul 15, 2022
@TachunLin
Copy link

Try to reproduce the issues on master-8f01b558-head (7/14).

For the three problems highlighted in this issue.

  • Problem 1: The Create button is not displayed on the image and volume page while already having project namespace assigned to the cluster member use
  • Problem 2: Users should not create resources in the harvester-public namespace, but the image creation page can select harvester-public -> This would be the current design
  • Problem 3: Create a namespace that does not belong to any Project and refresh page, this user does not have permission to view test-no-namespace -> This would be the expected behavior

Problem 1 can't be reproduced, when a cluster member privilege user have assigned the project and namespace
This user can see create button on the volume and image page
image
image
image

Since the only problem here can't be reproduced, thus close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/multi-tenancy kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue priority/0 Must be fixed in this release
Projects
None yet
Development

No branches or pull requests

6 participants