Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Modify local-rke-state secret to allow upgrade from previous version #3858

Closed
bk201 opened this issue May 5, 2023 · 3 comments
Closed
Assignees
Labels
area/rancher Rancher related issues area/upgrade blocker blocker of major functionality kind/bug Issues that are defects reported by users or that we know have reached a real release priority/0 Must be fixed in this release
Milestone

Comments

@bk201
Copy link
Member

bk201 commented May 5, 2023

Describe the bug

Rancher will check the secret, and upgrading RKE2 will fail.
The change causes it: rancher/rancher#41088
Related rancherd issue: rancher/rancherd#29, we need to make sure new clusters have the right secret too.

To Reproduce

  • Upgrade to a newer Harvester version contains the Rancher change.

Expected behavior

Support bundle

Environment

  • Harvester ISO version:
  • Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

@bk201 bk201 added kind/bug Issues that are defects reported by users or that we know have reached a real release priority/0 Must be fixed in this release area/upgrade labels May 5, 2023
@bk201 bk201 added this to the v1.2.0 milestone May 5, 2023
@guangbochen guangbochen added blocker blocker of major functionality area/rancher Rancher related issues labels May 25, 2023
@harvesterhci-io-github-bot
Copy link

harvesterhci-io-github-bot commented Jun 8, 2023

Pre Ready-For-Testing Checklist

  • ~If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:~~

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at: fix(upgrade): change type of local-rke-state secret #4050

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at: fix(upgrade): change type of local-rke-state secret #4050 fix(upgrade): change type of local-rke-state secret (backport #4050) #4060

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@harvesterhci-io-github-bot

Automation e2e test issue: harvester/tests#854

@irishgordo
Copy link

This looks good 😄 👍
Tested upgrade from v1.1.2 -> master-173b0824-head

Looking at secret after upgrade, via: kubectl get secrets local-rke-state -o yaml -n fleet-local
Noting:

apiVersion: v1
data:
  agentToken: dG9rZW4=
  serverToken: dG9rZW4=
kind: Secret
metadata:
  annotations:
    field.cattle.io/projectId: local:p-n7s5k
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","data":{"agentToken":"dG9rZW4=","serverToken":"dG9rZW4="},"kind":"Secret","metadata":{"annotations":{"field.cattle.io/projectId":"local:p-n7s5k"},"creationTimestamp":"2023-06-22T19:03:29Z","name":"local-rke-state","namespace":"fleet-local","resourceVersion":"129156","uid":"b7ea30a0-0024-4d92-83e8-d8ab01c66127"},"type":"rke.cattle.io/cluster-state"}
  creationTimestamp: "2023-06-22T21:09:59Z"
  name: local-rke-state
  namespace: fleet-local
  resourceVersion: "132410"
  uid: 19fba33b-4d49-4dc1-befa-fb8ee562e220
type: rke.cattle.io/cluster-state

Screenshot from 2023-06-22 14-50-57
Screenshot from 2023-06-22 14-48-02
Screenshot from 2023-06-22 13-57-13

I'll go ahead and close this out 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rancher Rancher related issues area/upgrade blocker blocker of major functionality kind/bug Issues that are defects reported by users or that we know have reached a real release priority/0 Must be fixed in this release
Projects
None yet
Development

No branches or pull requests

6 participants