Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v1.3] [ENHANCEMENT] Add UI for auto-rotate-rke2-certs setting #5748

Closed
harvesterhci-io-github-bot opened this issue May 7, 2024 · 2 comments
Assignees
Labels
kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue require-ui/small estimate 1-2 working days
Milestone

Comments

@harvesterhci-io-github-bot

backport the issue #5176

@harvesterhci-io-github-bot
Copy link
Author

harvesterhci-io-github-bot commented May 9, 2024

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Open Harvester GUI
  • Go to settings page
  • There should be a auto-rotate-rke2-cert setting.
  • Edit config -> enable -> check ExpiringInHours can set to 1 ~ 8759 (1 year)
  • Save config
  • Click Show auto-rotate-rke2-cert can see the config you set.
  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@irishgordo irishgordo self-assigned this May 24, 2024
@irishgordo
Copy link

Thanks for this @torchiaf - this looks good in v1.3.1-rc1 & Rancher v2.8.2 - 👍 I'll go ahead and close this out
Screenshot from 2024-05-29 17-23-51
Screenshot from 2024-05-29 17-22-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue require-ui/small estimate 1-2 working days
Projects
None yet
Development

No branches or pull requests

3 participants