Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SCSS in bower or remove sprite and use base64 #2347

Closed
nikolowry opened this issue Jun 16, 2015 · 6 comments
Closed

Include SCSS in bower or remove sprite and use base64 #2347

nikolowry opened this issue Jun 16, 2015 · 6 comments

Comments

@nikolowry
Copy link

Using custom styling and do not want to include the sprite image - but after trying numerous times to get the full repo via bower, I now have to manually copy and paste your sass here to overwrite (which means using the newest chosen after this ships will be impossible).

Reason being:
screenshot from 2015-06-16 11-25-59

@tristanlins
Copy link

I also never use the precompiled version, even though I think it's good that it is included. I always use the SASS/SCSS sources in my build chain.
For the moment I can help me out with the following line:
"chosen": "https://github.com/harvesthq/chosen.git#v1.4.1"

@AlJohri
Copy link

AlJohri commented Sep 25, 2015

+1 on using base64. seems like there's no downside and just easier usage for everyone else?
+1 also on serving raw scss via bower similar to the bootstrap-sass package on bower officially provided by twbs

see #2368 (comment) for details on removing compass as a dependency

@zyre91
Copy link

zyre91 commented Jan 20, 2016

+1 for sass files with bower so I can change the image path

@koenpunt
Copy link
Collaborator

koenpunt commented Oct 1, 2016

What should a package consist of? Source or compiled files? Or both? Because as far as I know it's not common to put source files in a package.

@kevin-brown
Copy link

Per bower/spec#43 :

Use source files with module exports and imports over pre-built distribution files.

Select2 (along with a bunch of others, include Bootstrap) made this change a little over a year ago, shortly after the spec was updated and the dust settled. select2/select2#3350

@tristanlins
Copy link

IMO the scss Files are part of the "executable". The css is more like a "dist" package. While the scss are the "executable" files. The scss files are the "sources" as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants