-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include SCSS in bower or remove sprite and use base64 #2347
Comments
I also never use the precompiled version, even though I think it's good that it is included. I always use the SASS/SCSS sources in my build chain. |
+1 on using base64. seems like there's no downside and just easier usage for everyone else? see #2368 (comment) for details on removing compass as a dependency |
+1 for sass files with bower so I can change the image path |
What should a package consist of? Source or compiled files? Or both? Because as far as I know it's not common to put source files in a package. |
Per bower/spec#43 :
Select2 (along with a bunch of others, include Bootstrap) made this change a little over a year ago, shortly after the spec was updated and the dust settled. select2/select2#3350 |
IMO the scss Files are part of the "executable". The css is more like a "dist" package. While the scss are the "executable" files. The scss files are the "sources" as well. |
Using custom styling and do not want to include the sprite image - but after trying numerous times to get the full repo via bower, I now have to manually copy and paste your sass here to overwrite (which means using the newest chosen after this ships will be impossible).
Reason being:
![screenshot from 2015-06-16 11-25-59](https://cloud.githubusercontent.com/assets/597310/8186839/8d75bb2c-141a-11e5-8d4e-79aabdc1f78b.png)
The text was updated successfully, but these errors were encountered: