Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS Support #270

Closed
yotammanor opened this issue Jul 13, 2017 · 3 comments · Fixed by #271
Closed

Add HTTPS Support #270

yotammanor opened this issue Jul 13, 2017 · 3 comments · Fixed by #271

Comments

@yotammanor
Copy link

Kikar.org is currently available only in http, this should change.

@uda uda self-assigned this Jul 13, 2017
@uda
Copy link
Member

uda commented Jul 13, 2017

I did my end and enabled HTTPS on the server, now you need to change http assets to https.

@uda uda removed their assignment Jul 13, 2017
@yotammanor
Copy link
Author

@uda what does it entail?

@uda
Copy link
Member

uda commented Jul 13, 2017

jquery and google fonts are loaded via http, both have https support, so there is no reason to use the http url.
jQuery: https://github.com/hasadna/kikar-hamedina/search?utf8=%E2%9C%93&q=jquery-latest.js&type=
Google APIs: https://github.com/hasadna/kikar-hamedina/search?utf8=%E2%9C%93&q=googleapis&type=

The best solution would be to adopt the schemaless approach which is to use URLs with neither HTTP or HTTPS, just //somehost/some/url. that is if they support both, this way your app will work fine locally and on production.

This is all about CSS and JS.

There is another issue with stuff like embedded videos from Mako, we will need to check how we solve it, since it isn't under our control what the MKs share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants