Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more details about a line in the line profile page #317

Open
NoamGaash opened this issue Dec 17, 2023 · 11 comments
Open

add more details about a line in the line profile page #317

NoamGaash opened this issue Dec 17, 2023 · 11 comments
Assignees
Labels
frontend frontend developers issue good first issue Good for newcomers line profile page

Comments

@NoamGaash
Copy link
Member

NoamGaash commented Dec 17, 2023

image
extract data from json, and show it in a visually appealing way

  • line origin / destination
  • bus company logo
  • etc
@NoamGaash NoamGaash added the frontend frontend developers issue label Dec 17, 2023
@NoamGaash
Copy link
Member Author

see #193 for more ideas

@YahavSofer
Copy link
Contributor

Please assign this issue to me :)
@NoamGaash

@NoamGaash
Copy link
Member Author

Thanks @YahavSofer ! I'm happy you're taking this one 💪

@NoamGaash
Copy link
Member Author

@YahavSofer hi, how is it going?

@TuvalSimha
Copy link
Collaborator

@NoamGaash
Is this still relevant? Can I have this one?

@NoamGaash
Copy link
Member Author

@TuvalSimha Sure! Good luck

@NoamGaash
Copy link
Member Author

@TuvalSimha let us know where are you standing and if you need any help! If you're still on this issue, please let us know and you'll be re-assigned
Thanks!

@dorinzrihen
Copy link
Collaborator

is it still relevant? i need a bit more information.
it looks like the data from the JSON is already in use. (logo, line origin / destination)

So, do I need to use another API call to show the table with the bus schedule?

image

@NoamGaash
Copy link
Member Author

@dorinzrihen Hi Dorin, thanks for raising this question!
Actually, I don't really get the idea of that table. The schedule of the bus can (theoretically) change every day - so why bother with a table?
I do believe that having a list of stations can be nice, but the page looks way better compared to the screenshot made when this issue was originally opened thanks to the great work of many volunteers.
Actually, I don't see the planned route - do we have a bug?
Anyway I guess this issue is not very relevant - perhaps it would be better to move on and make similar page for operators (see #458).

@NoamGaash
Copy link
Member Author

NoamGaash commented May 22, 2024

this api will get the stops list, if we want to show something fancy :)
https://open-bus-stride-api.hasadna.org.il/docs#/gtfs/list__gtfs_stops_list_get

@supervxn
Copy link
Collaborator

@dorinzrihen nice to see you in this issue too :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend frontend developers issue good first issue Good for newcomers line profile page
Projects
None yet
Development

No branches or pull requests

5 participants