feat: planned route map #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, welcome to our repo! |
NoamGaash
reviewed
Jan 28, 2024
| @@ -41,17 +48,17 @@ export function MapWithLocationsAndPath({ | |||
| onClick={toggleExpanded} | |||
| icon={<ExpandAltOutlined />} | |||
| /> | |||
| <MapContainer center={position.loc} zoom={8} scrollWheelZoom={true}> | |||
| <MapContainer center={position.loc} zoom={13} scrollWheelZoom={true}> | |||
NoamGaash
reviewed
Jan 28, 2024
|
hey!
so i just replaced the markers with a line that displays the route based on
the 'positions' given. Thats what i thought the issues was addressing.
Correct me if im wrong
בתאריך יום א׳, 28 בינו׳ 2024 ב-14:17 מאת Noam Gaash <
***@***.***>:
… Hi, welcome to our repo!
Thanks for the contribution. Just let me make sure I understand - it's not
about showing the actual / planned ride, it's just about adding the marker.
Am I missing something?
By the way, please run npm run lint:fix to fix all linting issues
—
Reply to this email directly, view it on GitHub
<#434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKX42S4EMSI5NALWTOZSBGDYQY6T3AVCNFSM6AAAAABCJOISSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU3TMOJRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Actually, this map doesn't show a planned ride - it's showing an actual ride that actually happened. The issue was about adding additional line/map showing the planning |
|
aiight i'll work on it:)
dont delete my branch yet
בתאריך יום ב׳, 29 בינו׳ 2024 ב-16:09 מאת Noam Gaash <
***@***.***>:
… Actually, this map doesn't show a planned ride - it's showing an actual
ride that actually happened. The issue was about adding additional line/map
showing the planning
—
Reply to this email directly, view it on GitHub
<#434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKX42S7YFKN6AXUBN5F7QR3YQ6UTBAVCNFSM6AAAAABCJOISSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUG43TCMJRG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This was
linked to
issues
Feb 8, 2024
|
hi, could you please clarify which issue you're solving, and attach an updated screenshot? thanks |
…n/open-bus-map-search into feat-planned-route-map
|
This was
unlinked from
issues
Feb 12, 2024
NoamGaash
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
after choosing a route & time of route, line of route is displayed on map
2 polylines are loaded:
also, added a map index showing which marker belongs to which route
screenshots