Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Treeview feature #558

Merged
merged 3 commits into from
Mar 7, 2024
Merged

feat: Added Treeview feature #558

merged 3 commits into from
Mar 7, 2024
+331 −46

Conversation

Darkmift
Copy link
Collaborator

@Darkmift Darkmift commented Mar 6, 2024

Description

  • I started work on a treeview display of json data
  • if its of any use let me know and Ill work out the visuals further

screenshots

image

@Darkmift Darkmift changed the title Added Treeview feature feat: Added Treeview feature Mar 6, 2024
NoamGaash
NoamGaash approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so cool! Thank you 🥇

src/pages/components/map-related/MapLayers/BusToolTip.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Preview: https://s3.amazonaws.com/noam-gaash.co.il/8187199584/open-bus/56fc2f2a9fc9922726ae71debecc2af571b6dd13/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/8187199584/open-bus/56fc2f2a9fc9922726ae71debecc2af571b6dd13/storybook/index.html

@Darkmift Darkmift closed this Mar 7, 2024
@NoamGaash
Copy link
Member

@Darkmift did you close the PR on purpose?

@Darkmift Darkmift reopened this Mar 7, 2024
@Darkmift
Copy link
Collaborator Author

Darkmift commented Mar 7, 2024

@Darkmift did you close the PR on purpose?

Hey apologies,
not sure when or how I closed this :/

@Darkmift Darkmift enabled auto-merge (squash) March 7, 2024 15:14
@Darkmift Darkmift merged commit 4aa6213 into hasadna:main Mar 7, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Draft
@Darkmift Darkmift deleted the feature-543-visualize-JSON branch March 7, 2024 15:28
@NoamGaash
Copy link
Member

Hi, I'm sorry - seems like npm run lint doesn't pass on this branch.
I'll fix the CI pipeline, and revert the changes,
Let's open a new PR with a valid version

Please try to avoid any, and to explicitly tell what types are expected for each of the functions and variables. It could help other developers to get a better understanding of what you did

NoamGaash added a commit that referenced this pull request Mar 7, 2024
@NoamGaash
Revert "feat: Added Treeview feature (#558)"
bc58970 
This reverts commit 4aa6213.
@NoamGaash NoamGaash mentioned this pull request Mar 7, 2024
Closed
@NoamGaash
Copy link
Member

I've opened this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

@aviv1620 aviv1620 Awaiting requested review from aviv1620 aviv1620 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Darkmift @NoamGaash