Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add language button #692

Merged
merged 3 commits into from
Apr 23, 2024
Merged

feat: add language button #692

merged 3 commits into from
Apr 23, 2024

Conversation

zushar
Copy link
Collaborator

@zushar zushar commented Apr 21, 2024 •
edited by R894

Description

add language button useng icon

screenshots

Screenshot 2024-04-21 175645
Screenshot 2024-04-21 175703

@zushar zushar requested a review from NoamGaash as a code owner April 21, 2024 14:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 21, 2024 •
edited

Preview: https://s3.amazonaws.com/noam-gaash.co.il/8798070321/open-bus/dbae28c21bce33b38b21c2b1d71b83734f0f129d/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/8798070321/open-bus/dbae28c21bce33b38b21c2b1d71b83734f0f129d/storybook/index.html

@zushar zushar enabled auto-merge (squash) April 22, 2024 03:45
@zushar zushar disabled auto-merge April 22, 2024 03:45
@zushar
reafctor: Update language toggle button to use useTranslation fonctio…
3eb61b0 
…n for aria-labal and title and chaing the translatio
@zushar zushar requested a review from Tamir198 April 23, 2024 09:26
@zushar zushar requested review from NoamGaash and removed request for NoamGaash April 23, 2024 09:29
Tamir198
Tamir198 approved these changes Apr 23, 2024
View reviewed changes
src/layout/sidebar/menu/Menu.tsx
{<LanguageToggle />}
</>
<Menu
onClick={handleClick}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats cleaner, good job

@zushar zushar merged commit 9556d92 into main Apr 23, 2024
18 checks passed
@zushar zushar deleted the lenguage-button branch April 23, 2024 11:42
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Draft
@zushar zushar mentioned this pull request Apr 30, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tamir198 Tamir198 Tamir198 approved these changes

@NoamGaash NoamGaash Awaiting requested review from NoamGaash NoamGaash is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zushar @NoamGaash @Tamir198