Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add caching to groupByService #727

Merged
merged 5 commits into from
May 5, 2024
Merged

feat: add caching to groupByService #727

merged 5 commits into from
May 5, 2024

Conversation

R894
Copy link
Collaborator

@R894 R894 commented May 3, 2024

Description

Adds caching to groupByService by adding the react-query package

closes #722

screenshots

Before

chrome_WkjrOYytIy.mp4

After

chrome_dfIbFlw6Mf.mp4

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!
You can consider removing the useEffect and make the query return the filtered data (maybe we can break it to fewer methods, to enhance code structure), but I'll respect different choice of implementation

@R894
Copy link
Collaborator Author

R894 commented May 4, 2024

Hi @NoamGaash ,
I've refactored the code the best I can, would be happy if you could review it again

@R894 R894 requested a review from NoamGaash May 4, 2024 14:22
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks so much better! 🤯

@R894 R894 merged commit c80851f into hasadna:main May 5, 2024
15 checks passed
@R894 R894 deleted the feat/caching branch May 5, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard data isn't cached
2 participants