Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new agencies should appear in the dashboard #797

Merged
merged 7 commits into from
Jun 21, 2024
Merged

fix: new agencies should appear in the dashboard #797

merged 7 commits into from
Jun 21, 2024

Conversation

asidelnik
Copy link
Collaborator

Get agency list - added date_from yesterday.
Resolves #789

@asidelnik asidelnik added the bug Something isn't working label Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9603519421/open-bus/21/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9603519421/open-bus/21/storybook/index.html

@asidelnik asidelnik changed the title Fix/new agencies should appear in the dashboard fix: new agencies should appear in the dashboard Jun 12, 2024
@asidelnik
Copy link
Collaborator Author

Code coverage was failing before I updated agencyList.ts.
npm run test:unit shows an error in: ArrivalByTimeChart.test.tsx

NoamGaash
NoamGaash approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@NoamGaash
Copy link
Member

seems like the falling test can be related to a backend change
hasadna/open-bus-stride-api#26

@NoamGaash NoamGaash merged commit ea7551e into main Jun 21, 2024
13 of 16 checks passed
@NoamGaash NoamGaash deleted the fix/new-agencies-should-appear-in-the-dashboard branch June 21, 2024 10:29
@NoamGaash
Copy link
Member

@all-contributors please add @asidelnik to code

@allcontributors allcontributors bot mentioned this pull request Jun 21, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@NoamGaash

I've put up a pull request to add @asidelnik! 🎉

@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new agencies should appear in the dashboard
2 participants
@asidelnik @NoamGaash