Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DateSelector selector validation message issues #818

Closed
YuvalMasada opened this issue Jun 18, 2024 · 0 comments
Closed

fix: DateSelector selector validation message issues #818

YuvalMasada opened this issue Jun 18, 2024 · 0 comments
Assignees
Labels
bug Something isn't working frontend frontend developers issue good first issue Good for newcomers

Comments

@YuvalMasada
Copy link
Collaborator

I found 2 issues with the DateSelector component validation message .

  1. When the DateSelector component is been used for selecting start & end dates there is a validation for when end date is earlier than the start date, But the validation message is not right.
  2. In the case where you have error validation message shown and you change the language the validation message will not change since it wrapped with useMemo hook.
@YuvalMasada YuvalMasada self-assigned this Jun 18, 2024
@NoamGaash NoamGaash added bug Something isn't working good first issue Good for newcomers frontend frontend developers issue labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend frontend developers issue good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants