Skip to content

Commit

Permalink
Merge pull request junit-team#319 from stefanbirkner/issue318
Browse files Browse the repository at this point in the history
Fixed junit-teamgh-318 (Empty message instead of null)
  • Loading branch information
dsaff committed Sep 19, 2011
2 parents 7663a30 + 1b809a4 commit 0a23cd6
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/main/java/junit/framework/AssertionFailedError.java
Expand Up @@ -11,6 +11,10 @@ public AssertionFailedError() {
}

public AssertionFailedError(String message) {
super(message);
super(defaultString(message));
}

private static String defaultString(String message) {
return message == null ? "" : message;
}
}
1 change: 1 addition & 0 deletions src/test/java/junit/tests/framework/AllTests.java
Expand Up @@ -18,6 +18,7 @@ public static Test suite() {
suite.addTestSuite(TestCaseTest.class);
suite.addTest(SuiteTest.suite()); // Tests suite building, so can't use automatic test extraction
suite.addTestSuite(TestListenerTest.class);
suite.addTestSuite(AssertionFailedErrorTest.class);
suite.addTestSuite(AssertTest.class);
suite.addTestSuite(TestImplementorTest.class);
suite.addTestSuite(NoArgTestCaseTest.class);
Expand Down
23 changes: 23 additions & 0 deletions src/test/java/junit/tests/framework/AssertionFailedErrorTest.java
@@ -0,0 +1,23 @@
package junit.tests.framework;

import junit.framework.AssertionFailedError;
import junit.framework.TestCase;

public class AssertionFailedErrorTest extends TestCase {
private static final String ARBITRARY_MESSAGE= "arbitrary message";

public void testCreateErrorWithoutMessage() throws Exception {
AssertionFailedError error= new AssertionFailedError();
assertNull(error.getMessage());
}

public void testCreateErrorWithMessage() throws Exception {
AssertionFailedError error= new AssertionFailedError(ARBITRARY_MESSAGE);
assertEquals(ARBITRARY_MESSAGE, error.getMessage());
}

public void testCreateErrorWithoutMessageInsteadOfNull() throws Exception {
AssertionFailedError error= new AssertionFailedError(null);
assertEquals("", error.getMessage());
}
}

0 comments on commit 0a23cd6

Please sign in to comment.