This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
2021-05-06 v. 1.0.7: added in-app update feature #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Added: - play core library dependency in app/build.gradle - flexible in-app update feature in MainActivity
fartem
suggested changes
May 7, 2021
| @@ -27,6 +38,9 @@ | |||
| public static final String URI_FROM_EXTERNAL_APP | |||
| = "com.smlnskgmail.jaman.hashcheckerlite.URI_FROM_EXTERNAL_APP"; | |||
|
|
|||
| private static final int MY_REQUEST_CODE = 1; | |||
There was a problem hiding this comment.
Please rename MY_REQUEST_CODE to REQUEST_APP_UPDATE.
| Snackbar snackbar = | ||
| Snackbar.make( | ||
| findViewById(android.R.id.content).getRootView(), | ||
| "An update has just been downloaded.", |
There was a problem hiding this comment.
You need to move all strings in UI to strings.xml file in resources. I'm translating this sentences to other languages.
1. Added: - strings from UI to strings.xml 2. Updated: - MY_REQUEST_CODE to REQUEST_APP_UPDATE in MainActivity
fartem
approved these changes
May 7, 2021
fartem
approved these changes
May 7, 2021
|
@vipozdn I'm added you to Contributors list in README.md. |
That's cool! Tnx! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Added:
Checklist
Common
UI
Logic
Changes
Describe all changes here:
Comments
Describe all additional information here.