Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Non-Free dependencies added with v1.0.8 #64

Closed
IzzySoft opened this issue May 10, 2021 · 4 comments
Closed

Non-Free dependencies added with v1.0.8 #64

IzzySoft opened this issue May 10, 2021 · 4 comments
Assignees
Labels
takes time for resolve Issues with problems/questions that take time for resolve/answer
Projects

Comments

@IzzySoft
Copy link

Describe the bug
The last release added Google Play Core to the app. I'm not sure if it was accidentally dragged in as a dependency (which I hope is the case, as then you'd certainly be interested to get it out again) – or added on purpose?

To Reproduce
Steps to reproduce the behavior:

  1. run apktool d hash-checker-lite_1.0.8.apk
  2. dive into the created directory structure
  3. find /com/google/android/play/core
  4. Look shocked (or at least pretend) 🙊

Expected behavior
No such thing there.

Screenshots

Libraries detected:
-------------------
* Android Support v4 (/android/support/v4): Development Framework
* AppCompat (/androidx/appcompat): Utility
* Constraint Layout Library (/androidx/constraintlayout): Utility
* Androidx Core (/androidx/core): Utility
* Lifecycle (/androidx/lifecycle): Utility
* Media (/androidx/media): Utility
* Preference (/androidx/preference): Utility
* Google Material Design (/com/google/android/material): Utility
* Google Play Core (/com/google/android/play/core): Utility NonFreeNet,NonFreeDep

Offending libs:
---------------
* Google Play Core (/com/google/android/play/core): NonFreeNet,NonFreeDep

Device (please complete the following information):

  • Device: n/a
  • OS: n/a
  • Version: 1.0.8

Additional context
Please let free software stay libre 🙏

@fartem fartem added the takes time for resolve Issues with problems/questions that take time for resolve/answer label May 11, 2021
@fartem fartem self-assigned this May 11, 2021
@fartem
Copy link
Member

fartem commented May 11, 2021

@IzzySoft I'm separating build for GitHub (and other non Google Play sources) in few days.

@IzzySoft
Copy link
Author

Thanks! So the next version should solve this then? To make sure, please let me know here when it's attached to releases so I can cross-check.

@fartem
Copy link
Member

fartem commented May 11, 2021

@IzzySoft Ok.

@fartem fartem added question Further information is requested and removed question Further information is requested labels May 11, 2021
@fartem fartem added this to To do in 1.2.0 May 17, 2021
@fartem fartem removed this from To do in 1.2.0 May 30, 2021
@fartem fartem added this to To do in 1.1.0 May 30, 2021
@fartem
Copy link
Member

fartem commented Sep 26, 2021

Closed because the app going to the Archive.

@fartem fartem closed this as completed Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
takes time for resolve Issues with problems/questions that take time for resolve/answer
Projects
No open projects
1.1.0
To do
Development

No branches or pull requests

2 participants