This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Feature #65
Merged
Feature #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added: - method that opens Google Play link in WebUtils class
1. Added: - canShowRateAppDialog, increaseHashGenerationCount, save and getIntPreference methods to SharedPreferencesSettingsHelper class; - key_hash_generation_count string to strings-non-translatable.
1. Added: - AppAlertDialog that shows Rate App dialog in HashCalculatorFragment; - rate app strings to strings.xml.
Closed
fartem
suggested changes
May 13, 2021
| @@ -97,6 +100,24 @@ | |||
| ); | |||
| } else { | |||
| etGeneratedHash.setText(hashValue); | |||
| SharedPreferencesSettingsHelper settingsHelper = new SharedPreferencesSettingsHelper(context); | |||
There was a problem hiding this comment.
You need to use SettingsHelper instance from Dagger injection. If a class don't contains SettingsHelper injection, add it as local public field with @Inject annotation.
1. Added: - usage of SettingsHelper instance from Dagger injection in HashCalculatorFragment; - declaration of methods from SharedPreferencesSettingsHelper class to SettingsHelper interface; - RateAppDialogTest class extending BaseUITest.
fartem
suggested changes
May 14, 2021
| @@ -41,4 +43,7 @@ | |||
|
|
|||
| void setRefreshSelectedFileStatus(boolean status); | |||
|
|
|||
| boolean canShowRateAppDialog(Context context); | |||
There was a problem hiding this comment.
Delete Context argument from canShowRateAppDialog and increaseHashGenerationCount methods. Context available in interface realization (SharedPreferencesSettingsHelper).
|
@vipozdn Also, check Codacy report. In last commit you have some code issues. |
3. Updated: - documentation by fartem. 4. Deleted: - unused import at HashCalculatorFragment class.
1. Deleted: - Context argument from canShowRateAppDialog and increaseHashGenerationCount methods at SettingsHelper, SharedPreferencesSettingsHelper and HashCalculatorFragment; - unused import at SettingsHelper class.
fartem
approved these changes
May 17, 2021
|
@vipozdn thanks. |
I'm always happy to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Common
UI
Logic
Changes
Describe all changes here:
Comments
Describe all additional information here.