Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide clear buttons when hash EditText fields is empty #30

Merged
merged 3 commits into from Jun 28, 2020
Merged

Hide clear buttons when hash EditText fields is empty #30

merged 3 commits into from Jun 28, 2020

Conversation

marwa-eltayeb
Copy link
Contributor

Checklist

Common

  • I am ran the app before creating PR
  • I am ran all tests before creating PR

UI

  • I am ran the app for visual checks.

Logic

  • I am tested basic app functionality.

Changes

Describe all changes here:

  • First; Hide clear button (ivCustomHashClear) when hash EditText (etCustomHash) is empty
  • Second; Hide clear button (ivGeneratedHashClear) when hash EditText (etGeneratedHash) is empty

Comments

Describe all additional information here.

@fartem fartem changed the base branch from master to 3.4.0 June 28, 2020 17:03
@fartem fartem merged commit 38bd69f into hash-checker:3.4.0 Jun 28, 2020
@fartem
Copy link
Member

fartem commented Jun 28, 2020

@marwa-eltayeb thanks for PR. Your changes applied to the next version of the app.

@marwa-eltayeb
Copy link
Contributor Author

@fartem You are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marwa-eltayeb @fartem