Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fill functionality for background color #22

Closed
wants to merge 1 commit into from
Closed

feat: add fill functionality for background color #22

wants to merge 1 commit into from

Conversation

HrishabhCodes
Copy link

@HrishabhCodes HrishabhCodes commented Mar 2, 2022 •
edited by vedant-jain03

This PR is related to issue #4. I have removed the theme toggler and added the filling functionality to change the background color of the canvas.

fixes #4

Screen_Recording_2022-03-02_at_6.17.31_PM.mov

@netlify
Copy link

netlify bot commented Mar 2, 2022 •
edited

✔️ Deploy Preview for hashdefine-whiteboard ready!

🔨 Explore the source changes: da17a3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/hashdefine-whiteboard/deploys/621f882b1e3af400085e56b2

😎 Browse the preview: https://deploy-preview-22--hashdefine-whiteboard.netlify.app/

@DhairyaBahl
Copy link
Member

@HrishabhCodes You don't have to remove that toggle button ! You have to change the background color of canvas as a part of this issue.

@DhairyaBahl DhairyaBahl added the GSSoC22 This tag represents the issue or PR under the scope of Girls-script Summer of Codes' 22 label Mar 2, 2022
@HrishabhCodes
Copy link
Author

HrishabhCodes commented Mar 3, 2022 •
edited

@HrishabhCodes You don't have to remove that toggle button ! You have to change the background color of canvas as a part of this issue.

Just to be sure with my tasks, I have to add the theme toggler again. Is the background color functionality added by me fine?
I have one more doubt regarding themes. What should be changed? Only the canvas or sidebar and header as well?

@vedant-jain03 vedant-jain03 added the Level2 Medium label Mar 7, 2022
@vedant-jain03 vedant-jain03 mentioned this pull request Apr 18, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhairyaBahl DhairyaBahl Awaiting requested review from DhairyaBahl

Assignees
No one assigned
Labels
GSSoC22 This tag represents the issue or PR under the scope of Girls-script Summer of Codes' 22 Level2 Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark Mode is not working
3 participants
@HrishabhCodes @DhairyaBahl @vedant-jain03