New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC: Attach type information to nodes #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have a bunch of the test cases changed?
Also, the entries that map And, the tc state needs to be somehow externally accessible, which means all the tc data structures need to be public or in their own crate? |
@feds01 Yeah, I guess that is the next step once these entries will actually be used. However, I think that whichever crate needs them should probably just depend on TC. So they could just stay where they are in global storage for now.. |
Since the |
Yeah lowering should definitely depend on TC, because that is the utility it uses to actually know what to lower it to... I guess we can split TC impl from TC primitives into different crates but that might not bring so many advantages. |
This PR adds a store
NodeInfoStore
which mapsAstNodeId
s toTermId
s andPatId
s. It is a necessary step for implementing mono/lowering to IR, as well as any post-TC semantic stages.Closes #240.