Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect and warn when users try to use -r with a directory #1191

Closed
roycewilliams opened this issue Mar 19, 2017 · 0 comments
Closed

detect and warn when users try to use -r with a directory #1191

roycewilliams opened this issue Mar 19, 2017 · 0 comments

Comments

@roycewilliams
Copy link
Member

roycewilliams commented Mar 19, 2017

I discovered this issue while researching #1185.

Reading all rules in a directory was a recent feature request in #1182 . New users may try this. If they do, instead of rejecting the attempt early, hashcat goes through the full setup phase (hash loading, hardware initialization, potfile processing, etc.) and then pauses for a very long time at "Generated bitmap tables":

$./hashcat -m 100  -a 0 -r /var/tmp/emptydir/ target.hashes
hashcat (v3.40-49-g20057d8) starting...

[snip]

Generated bitmap tables...^C

It appears that hashcat may be trying to parse the directory as a ruleset? Not sure. If so, this could have weird side effects we should avoid.

Suggested solution: check if -r parameter is a directory, abort early, and suggest to the user the alternative that @jsteube suggested in #1182, but phrased to be platform-independent - someting like "Rules cannot be loaded from a directory. Concatenate your rules into a single file instead". This could head off a FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant