Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: skip instead of abort on BOM detection #2504

Closed
roycewilliams opened this issue Jul 30, 2020 · 2 comments
Closed

feature: skip instead of abort on BOM detection #2504

roycewilliams opened this issue Jul 30, 2020 · 2 comments

Comments

@roycewilliams
Copy link
Member

When processing a large number of files, it would be useful to skip files with they Byte Order Mark (BOM) and move on to the next wordlist/mask/etc, instead of completely aborting the hashcat run.

@solardiz
Copy link
Contributor

FWIW, in JtR we currently don't even skip such files - we merely warn, but continue trying to process the rest of the file anyway (for both password hash and wordlist files). I think hashcat can do the same, and thus handle this problem gracefully not only when run on multiple files. Recent JtR fix: openwall/john#4306

@jsteube
Copy link
Member

jsteube commented Jun 29, 2021

This has been addressed with commit 254e33c as discussed. Skip the BOM instead of abort.

We could add some more text to the warning, for instance telling the user the BOM was ignored and they should use --encoding-from but OTOH we could automatically do it, too. For instance if we detect a BOM in a wordlist, but we would need some sort of mapping between the detected BOM and the ascii-string taken from internal iconv. I am wondering if iconv has some header files we could use for that because I want to avoid to reinvent the wheel.

@jsteube jsteube closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants