Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] "Input Queue" status line when using custom charset masks from file #934

Closed
llamasoft opened this issue Dec 29, 2016 · 1 comment

Comments

@llamasoft
Copy link
Contributor

llamasoft commented Dec 29, 2016

As the title says, the "Input Queue" status line is replaced with "Input Charset" when the mask has a custom charset definition even if it's being read from file.

Example: create a file with the following lines and use the file as an input for a mask attack.:

aeiou,?d?d?d?d?d?1
aeiou,AEIOU,?d?d?d?d?1?2
abcdef,?d?d?d?d?d?1

Without the "input queue" status, it's difficult to tell your progress into the mask file. You can manually find your position by searching your mask file for the charsets and mask, but it can get tedious. The above example is pretty short, but hopefully it illustrates the issue.

In lieu of a pull request, I suggest changing these lines to:

    case INPUT_MODE_MASK:
    case INPUT_MODE_MASK_CS:

      event_log_info (hashcat_ctx,
        "Input.Queue......: %d/%d (%.02f%%)",
        hashcat_status->input_base_offset,
        hashcat_status->input_base_count,
        hashcat_status->input_base_percent);

      break;

(Added the case label for INPUT_MODE_MASK_CS)

P.S. Sorry for opening so many issues today. Keep up the good work!

@jsteube
Copy link
Member

jsteube commented Dec 29, 2016

No worries, please keep opening good issues like that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants