Fix LLVM compilation for OpenCL kernels #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks almost good. Can you please try to put it into include/kernel_vendor.h instead? That's where the extensions usually are called from. If that's not possible, for whatever reason, please tell me and we'll merge it as it is |
Fix LLVM compilation for OpenCL kernels Whoops
|
ah that file looks to be a much better fit! I got a bit confused on where to place the statement. I believe LLVM's OpenCL support works on both AMD and Nvidia cards. I'm only testing AMD at the moment though. In any case the change has been force pushed. |
|
Thanks! |
jsteube
added a commit
that referenced
this pull request
Apr 20, 2016
|
@neheb Can you please test if it's still working on LLVM |
|
yeah it's working. still doesn't compile right but that's a different issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They otherwise fail with "static type not supported". LLVM only does OpenCL 1.1.