Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving executable in pe-bear corrupts its icon #50

Closed
not6 opened this issue Aug 31, 2022 · 7 comments
Closed

Saving executable in pe-bear corrupts its icon #50

not6 opened this issue Aug 31, 2022 · 7 comments
Assignees
Labels

Comments

@not6
Copy link

not6 commented Aug 31, 2022

seems to happen to every executable i try including pe-bear itself
how to replicate: open exe in pe-bear then save it, nothing else has to be done, no options have to be changed

a byte in the resource directory is changed for no apparent reason, causing this strange effect

examples:
Example 1
Example 2

@hasherezade
Copy link
Owner

hi @not6 !
you are right. thank you for reporting. it will be fixed in the upcoming release.

@not6
Copy link
Author

not6 commented Aug 31, 2022

hi @not6 ! you are right. thank you for reporting. it will be fixed in the upcoming release.

glad I could help! thank you as well

@hasherezade
Copy link
Owner

hasherezade commented Aug 31, 2022

@not6 - I fixed this bug and made a test build for you. please let me know if everything is fine now.
I will ping you when the official release is ready.

@hasherezade hasherezade self-assigned this Aug 31, 2022
@not6
Copy link
Author

not6 commented Aug 31, 2022

@not6 - I fixed this bug and made a test build for you. please let me know if everything is fine now:

* [PE-bear_0.5.5.6-rc2_x64_win_vs17.zip](https://github.com/hasherezade/pe-bear-releases/files/9463534/PE-bear_0.5.5.6-rc2_x64_win_vs17.zip)

I will ping you when the official release is ready.

sorry for the late-ish response, i have tried your build and it's working perfectly. thank you!

@hasherezade
Copy link
Owner

@not6 - thanks for checking! I am glad that all works fine now. feel free to ping me anytime if you notice that something is not ok.

@hasherezade
Copy link
Owner

@not6
Copy link
Author

not6 commented Sep 6, 2022

just did a couple tests and it works perfectly! thank you and sorry i couldn't have checked earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants