Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export AWS partitions and regions as Go constants #649

Open
ewbankkit opened this issue Sep 12, 2023 · 2 comments
Open

Export AWS partitions and regions as Go constants #649

ewbankkit opened this issue Sep 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS SDK for Go v1 exports AWS partition and region names as constants in https://github.com/aws/aws-sdk-go/blob/main/aws/endpoints/defaults.go. AWS SDK for Go v2 does not export these names.
With the deprecation of AWS SDK for Go v1 and the extensive use of these constants in the Terraform AWS Provider there is the need to define them somewhere.
As these values are already in use in internal/endpoints/endpoints.go it seems to make sense to export these values as constants from this module.

@ewbankkit ewbankkit added the enhancement New feature or request label Sep 12, 2023
@ewbankkit
Copy link
Contributor Author

@gdavison
Copy link
Contributor

Related: #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants