Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use azure VM resource name as name in boundary #6

Closed

Conversation

jwueste
Copy link

@jwueste jwueste commented Mar 29, 2022

As mentioned in issue #1821 in boundary project (hashicorp/boundary#1821), dynamic host catalogs are nearly unusable via admin console or desktop app, because discovered hosts don't get a human identifiable name. Only internal id is displayed.
With this PR, the azure resource name is used as hostname in azure.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 29, 2022

CLA assistant check
All committers have signed the CLA.

@talanknight
Copy link
Contributor

talanknight commented May 31, 2022

Thank you so much for your contribution @jwueste ! My understanding is that the last segment of an Azure resource id is not guaranteed to be unique across resource types or resource groups. Is that correct?
If so having the Boundary resource's name be the last part of the azure resource id could cause uniqueness constraint violations in Boundary since Boundary requires all hosts in a specific host catalog to have a unique name. We potentially will want to be able to sync in more resource types beyond just VMs and, as far as I'm aware, Azure does not constrain resource names across resource types.

@stefan-caraiman
Copy link

Are there any plans on offering a way to get a human friendly name to show up in the hosts section? If the problem is that Azure does not ensure uniqueness across Resource groups and cross other resources, can't we just add the resource name as a new field which does not have this constraint? 🤔
What do you think @talanknight @jwueste ?

@xingluw
Copy link

xingluw commented Jan 9, 2023

Hi @stefan-caraiman, we are actively looking at resolving it in the way you described, you can track updates in #1821

@hugoghx
Copy link

hugoghx commented Apr 17, 2023

Hello @jwueste, we have took on this task internally and I just merged changes on this so I'll be closing this for #11. Thanks for doing this!

@hugoghx hugoghx closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants