-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Consul on Kubernetes Helm Chart repo moving to hashicorp/consul-k8s
#638
Comments
hashicorp/consul-k8s
hashicorp/consul-k8s
When is this change expected to occur? I think this makes a lot of sense and am happy to see consolidation of the two repositories as there was always two places to check for issues before filing or making sure your issue is in right repository. |
Hi @shellfu we're looking to making these changes likely in late August. We don't know the exact timing yet, but we will make sure that issues are migrated over properly when this is done. Thanks for your feedback! |
hashicorp/consul-k8s
hashicorp/consul-k8s
Closing as the migration has happened! |
Hello Consul K8s Community!
We are planning on consolidating our Consul Helm and Consul K8s repos soon! TLDR: The HashiCorp Helm chart will be moving to hashicorp/consul-k8s. We target completing the migration before the end of August 2021.
Background
For users, the separate repositories lead to difficulty on new releases and confusion surrounding versioning. Most of the time new releases that include changes to consul-k8s also change consul-helm. But separate repositories mean separate GitHub PR's and added confusion in opening new Github Issues. In addition, we maintain separate versions of the
consul-k8s
binary and the Consul Helm chart, which in most cases are more tightly coupled together with dependencies. This versioning strategy has also led to confusion as to which Helm charts are compatible with which versions ofconsul-k8s
.Proposal
The single repository name will be
consul-k8s
. It will contain the Helm charts, control-plane code, and other components of Consul on Kubernetes. The originalconsul-k8s
binary will be renamed toconsul-k8s-control-plane
, and an upcoming user-facing CLI binary will be calledconsul-k8s
.Some additional details regarding the Consul Helm chart migration:
consul-helm
toconsul-k8s
.consul-helm
will not be migratedconsul-k8s
. Users will need to do that themselves (see below for instructions), since it would be too complex to perform the migration with CI automation. The new repo will have acharts
folder where the Helm chart will reside and PRs can be made against the contents in that folder in the same structure as before.consul-helm
repo, as no more changes will be made to the repository.consul-k8s
binary will now exist in the following Docker Hub repo:hashicorp/consul-k8s-control-plane
.https://helm.releases.hashicorp.com
).After the integration, all of our Consul on Kubernetes components will be versioned together, and the release process will consist of creating a new tag of the repository, and using that tag as the version for the control-plane docker image, the upcoming CLI binary, and the Helm charts.
Migrating Existing Pull Requests
If you have existing pull requests to consul-helm you will need to migrate them to consul-k8s. This is how to do so:
List the commit sha's from your PR:
In this example my two shas are
b0cc99dd1bae59224e807b0785a5819f1e359ea7
and39f3fd9927a01f0fe6ee8645443c56a7ea5a3931
.Fork consul-k8s (https://github.com/hashicorp/consul-k8s)
Clone consul-k8s locally
Add your consul-helm fork as a remote:
Run git fetch
Switch to a new branch that you'll use for your PR
Cherry-pick each commit sha from your PR into consul-k8s starting with the oldest sha
Even though the directory of the helm chart moved into charts/consul, the cherry-pick should apply.
Push the branch and open a new PR into consul-k8s
Close the old PR with a comment linking it to the new PR in consul-k8s
The text was updated successfully, but these errors were encountered: