Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose imagePullPolicy #1197

Closed
washtubs opened this issue Apr 29, 2022 · 2 comments · Fixed by #2310 or #3991
Closed

Expose imagePullPolicy #1197

washtubs opened this issue Apr 29, 2022 · 2 comments · Fixed by #2310 or #3991
Labels
type/enhancement New feature or request

Comments

@washtubs
Copy link
Contributor

washtubs commented Apr 29, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

We are deploying this as a subchart, and trying to prevent forking. It is possible but very difficult to modify imagePullPolicy with kustomize, and it would be nice if this was simply exposed in the values.yaml like it is for vault.

Feature Description

Expose an imagePullPolicy attribute. A global attribute would be acceptable. Doesn't have to be one for the normal image and another for imageK8s, but I'll just point out that that's what vault does.

Use Case(s)

Changing the imagePullPolicy to Always in cases where we override the image to something with a fixed tag where the underlying image is updated in the registry. Not a great practice but still valid, and I'm sure there are plenty of other valid use cases.

Contributions

I would be happy to contribute.

@washtubs washtubs added the type/enhancement New feature or request label Apr 29, 2022
@david-yu
Copy link
Contributor

david-yu commented Jun 2, 2022

Hi @washtubs that is a good feature request and I have also noticed that there is a imagePullPolicy with the vault Helm chart. Would you be willing to open up a PR that proposes how we could address this issue?

@david-yu david-yu linked a pull request Jun 13, 2023 that will close this issue
2 tasks
@david-yu
Copy link
Contributor

david-yu commented Jul 5, 2023

Re-opening as the changes had to be reverted prior to our GA release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
2 participants