-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health checks, Kubernetes probes and Connect #155
Comments
We're experiencing the same issue here, in our use case TCP health check is not enough. Without integration with k8s readiness/liveness probes requests are frequently being routed to dead pods. |
Thanks Pavel, what do you think about us automatically hooking into the kube readiness probes? |
Thanks for your response @lkysow . Readiness probe hook would be the best option imo. Liveness probe by it's nature doesn't guarantee that pod is ready to accept traffic (at least not always) while readiness probe hook could help to leverage native k8s capabilities without need to duplicate health checks (k8s + consul). Also in such case when not all services deployed in kubernetes are connect-enabled this approach allows to keep consistent way of health check definitions. |
Hello, We're investing using Consul connect for our service mesh and have seen this issue as well. We're heavy users of health checks for our existing consul service discovery. Does any workaround exist enable consul to check the health of a connect enabled service? |
The only workaround I can think of right now is to add a check yourself via consul's api for each connect pod. |
Health checks have now been released! We now sync Kubernetes probes to Consul. See https://www.consul.io/docs/k8s/connect/health. This was released in consul-helm v0.26.0. |
Currently the Consul Connect integration doesn't hook into Kubernetes health/liveliness probes nor do we provide a way to register Consul health checks. Thus when a Pod goes unhealthy we still route to it.
The text was updated successfully, but these errors were encountered: