Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd-servicedefaults misses LocalConnectTimeoutMs and LocalRequestTimeoutMs #1641

Closed
erdanzhang opened this issue Oct 21, 2022 · 0 comments · Fixed by #1647
Closed

crd-servicedefaults misses LocalConnectTimeoutMs and LocalRequestTimeoutMs #1641

erdanzhang opened this issue Oct 21, 2022 · 0 comments · Fixed by #1647
Labels
type/enhancement New feature or request

Comments

@erdanzhang
Copy link
Contributor

erdanzhang commented Oct 21, 2022

Similar to previous issue, #1400
Consul CRD serviceDefauts seems miss configuration LocalConnectTimeoutMs LocalRequestTimeoutMs which is available to use on hcl type config.

Feature Description
Consul service-defaults config entry supports setting LocalConnectTimeoutMs and LocalRequestTimeoutMs
This feature is supported in consul agent binary and hcl config, but not in k8s crd

Use Case(s)
The user needs to config timeout for upstream connection, otherwise, the defaults value for LocalRequestTimeoutMs (15s) might be too short for some long-running request

cc @david-yu @thisisnotashwin @t-eckert
(Since I saw your guys made the contribution on PR #1437)

Seems the changes required are very similar to PR: #1437
So, I basically take it as reference, and add two fields "LocalConnectTimeoutMs" and "LocalRequestTimeoutMs" in a similar fashion, please take a look.

🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖
PR link:
#1647

🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
1 participant