Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HCP Observability ClientID and ClientSecret #2958

Merged
merged 3 commits into from Sep 19, 2023

Conversation

clly
Copy link
Contributor

@clly clly commented Sep 14, 2023

Changes proposed in this PR:

  • When using the cloud preset, Attempt to fetch the observability credentials and use them when configuring the consul-telemetry-collector

How I've tested this PR:

  • unit tests
  • manual execution

How I expect reviewers to test this PR:

Checklist:

@clly clly force-pushed the clly/observability-credentials branch from 297f7b2 to 84dfaf5 Compare September 18, 2023 20:40
@clly clly added the pr/no-backport signals that a PR will not contain a backport label label Sep 18, 2023
@clly clly marked this pull request as ready for review September 19, 2023 17:17
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending that a collector test passes ok.

@clly clly added backport/1.2.x 1.2.x release branch and removed pr/no-backport signals that a PR will not contain a backport label labels Sep 19, 2023
@clly clly merged commit 1b52ac3 into main Sep 19, 2023
32 of 37 checks passed
@clly clly deleted the clly/observability-credentials branch September 19, 2023 21:38
clly added a commit that referenced this pull request Sep 19, 2023
* feat: Add HCP Observability ClientID and ClientSecret

* go mod tidy

* changelog
clly added a commit that referenced this pull request Sep 20, 2023
* feat: Add HCP Observability ClientID and ClientSecret (#2958)

* feat: Add HCP Observability ClientID and ClientSecret

* go mod tidy

* changelog

* Empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.2.x 1.2.x release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants